-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(carousel): fix keyboard navigation - FRONT-4316 #3300
Conversation
emeryro
commented
Mar 22, 2024
•
edited
Loading
edited
- allow user to go to the slide content by pressing "tab"
- improve accessibility markup with role "tablist", "tabpanel" and "tab"
- make focus visible on the buttons
mmh..i find this very confusing and counter intuitive, so the user typically reaches the element using tab, it will start navigating in the "controls" of the carousel but eventually, once reaching the slides indicators it will see his focus move into the slide, tabbing again (if nothing else is focusable) he will not be able to reach the buttons but he we'll start focusing outside of the carousel. In my opinion, maybe arrow up could have been used for introducing the possibility of reaching the slide content, using tab breaks the most standard keyboard navigation use case. |
Regine confirmed in https://citnet.tech.ec.europa.eu/CITnet/jira/browse/ECL-891 that the behavior is as expected now |