Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): fix keyboard navigation - FRONT-4316 #3300

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Mar 22, 2024

  • allow user to go to the slide content by pressing "tab"
  • improve accessibility markup with role "tablist", "tabpanel" and "tab"
  • make focus visible on the buttons

Copy link

github-actions bot commented Mar 22, 2024

@github-actions github-actions bot temporarily deployed to pull request March 22, 2024 08:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 22, 2024 12:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 27, 2024 07:38 Inactive
@emeryro emeryro marked this pull request as ready for review March 27, 2024 07:42
@github-actions github-actions bot temporarily deployed to pull request March 27, 2024 10:24 Inactive
@planctus
Copy link
Collaborator

mmh..i find this very confusing and counter intuitive, so the user typically reaches the element using tab, it will start navigating in the "controls" of the carousel but eventually, once reaching the slides indicators it will see his focus move into the slide, tabbing again (if nothing else is focusable) he will not be able to reach the buttons but he we'll start focusing outside of the carousel.
Furthermore i don't understand why the buttons, when they get focused, they lose their styles as "current", so that only when you move the focus out of them you get the style back.

In my opinion, maybe arrow up could have been used for introducing the possibility of reaching the slide content, using tab breaks the most standard keyboard navigation use case.

@emeryro
Copy link
Contributor Author

emeryro commented Apr 4, 2024

Regine confirmed in https://citnet.tech.ec.europa.eu/CITnet/jira/browse/ECL-891 that the behavior is as expected now

@emeryro emeryro removed the Question label Apr 9, 2024
@planctus planctus merged commit 116e4bf into v4-dev Apr 9, 2024
7 checks passed
@planctus planctus deleted the FRONT-4316-acc-carousel-tab branch April 9, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants