Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list-illustration): fix display issue - FRONT-3997 #2909

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix(list-illustration): fix display issue - FRONT-3997 #2909

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00d801b
fix display issue
emeryro Jun 15, 2023
5d7a294
change breakpoint
emeryro Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/implementations/vanilla/components/list-illustration/_list-illustration.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,14 @@ $_icon_color: null !default;
}
}

@include breakpoints.up('m') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why do we have this css?

.ecl-list-illustration--zebra {
    -webkit-margin-start: -50vw;
    left: 50%;
    margin-inline-start: -50vw;
    position: relative;
    width: 100vw;
}

what is this for? The proposed change fixes the main issue with our demos, but still it feels we shouldn't force the element to take full width even in mobile and tablets, potentially we could be doing this still in a layout with columns, for instance, and in any case it's not really clear what is that we want to achieve with that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a request from COMM, to have the zebra list look less like cards when on mobile...
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but if you think that it would be too dangerous to keep it, we can put it away, at least for now

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not really get the "comparison" with cards, but anyway, like this is surely safer, if we limit it to the mobile breakpoint.
Just to understand, this is done to ensure that the grey background of the zebra would cover the full width of the viewport regardless of a container that could set a padding, basically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes basically this is to have no white padding around the grey area, so it looks more like a vertical list of items

.ecl-list-illustration--zebra {
left: auto;
margin-inline-start: 0;
width: auto;
}
}

// Centered items
.ecl-list-illustration--centered {
&.ecl-list-illustration--col-2,
Expand Down