Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): Randomising generation of default id for select all checkbox - FRONT-3966 #2876

Merged
merged 1 commit into from
May 25, 2023

Conversation

planctus
Copy link
Collaborator

No description provided.

Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a random number should work indeed, but don't we already have a unique id for the select field, to be reused here?

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request May 24, 2023 13:35 Inactive
@planctus
Copy link
Collaborator Author

planctus commented May 24, 2023

i'd say that nothing is really "unique" here, not even with this random string appended.. :)
what we currently do for all these checkboxes is to create an id starting from 'select-multiple' by default and for the standard ones we add the value of the option so it becomes select-multiple-{value}, we don't set any id for the select by ourselves, instead.

By the way this id we start from is an option of the js, so potentially the users could fix on their side, but i think that autoInit is always used for everything on the implementation side, so better doing this on our side.

@planctus planctus removed the Question label May 24, 2023
@emeryro emeryro merged commit 8543243 into v3-dev May 25, 2023
@emeryro emeryro deleted the FRONT-3966-Select-all-id branch May 25, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants