Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): Sub items not displayed - FRONT-3949 #2861

Merged
merged 4 commits into from
May 10, 2023

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented May 10, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented May 10, 2023

@github-actions github-actions bot temporarily deployed to pull request May 10, 2023 07:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 10, 2023 07:35 Inactive
@emeryro emeryro marked this pull request as ready for review May 10, 2023 08:54
@emeryro emeryro requested a review from a team May 10, 2023 08:54
@github-actions github-actions bot temporarily deployed to pull request May 10, 2023 09:07 Inactive
@planctus
Copy link
Collaborator

For the sake of this bug we introduced, this is fixing it but my gut feeling is that this javascript should be entirely refactored, we strongly rely on an html attribute value, repeating over and over the same checks, it's out of control and with a certain suprise i've jst realised that this menu won't simply work without javascript:
we do make an attempt, with our "no-js" class that we are not setting ourselves, but that's not going to work. I was still thinking that the opening of the dropdown was driven by css but we are actually only relying on javascript and only on mouse events, not touch events, so this would not work on an ipad, like..

@github-actions github-actions bot temporarily deployed to pull request May 10, 2023 11:06 Inactive
@planctus planctus merged commit e8f2951 into v3-dev May 10, 2023
@planctus planctus deleted the FRONT-3949-menu-visibility branch May 10, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants