-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(website): Fixing getting started and typography pages - FRONT-3925 #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing review_id
…opa-component-library into chore-fixing-website-pages
emeryro
changed the title
chore(website): Fixing getting started and typography pages
chore(website): Fixing getting started and typography pages - FRONT-3925
Apr 18, 2023
emeryro
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing the getting started and typography (guildelines) pages in the website.
Additionally this brings back the sri hashes in the getting started pages that were not working since we moved to github actions.
Unfortunately there is no "preview" where to see this working, but this is the html snippet in the getting started page where the values are correctly appearing:
The sri file is generated in scripts and then moved during the website build in dist/packages, it is correctly deployed to github as it can be seen here:
https://github.com/ec-europa/europa-component-library/releases/tag/v3-test-sri