Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): Fixing getting started and typography pages - FRONT-3925 #2832

Merged
merged 17 commits into from
Apr 18, 2023

Conversation

planctus
Copy link
Collaborator

@planctus planctus commented Apr 13, 2023

This is fixing the getting started and typography (guildelines) pages in the website.
Additionally this brings back the sri hashes in the getting started pages that were not working since we moved to github actions.
Unfortunately there is no "preview" where to see this working, but this is the html snippet in the getting started page where the values are correctly appearing:

<details>
  <summary>SRI hashes (click to expand)</summary>
  <ul>
    <li>
      <p class="iRCJJeCgSXzX9ymLg1TH">for <code>ecl-ec.css</code>: <code>sha256-MMxHrF78tyV3pNw5vfltXI4IZVabHRY5jRELJIh2lPw= sha384-x8P09uLwQRW5qOL5KhANn7+4NNd/DipzqVr7a+lw35ctzM6q+ZcAw8aV+7i2yUQ6 sha512-6zw2Q1ofY5ubR7kHOmEvXAczQXhqhdUTijoAFJ2HNorvSm3ffv6LSRntFSZefkFykeTx7Y1/9i7nmIpiE1y4WA==</code></p>
    </li>
    <li>
      <p class="iRCJJeCgSXzX9ymLg1TH">for <code>ecl-ec-print.css</code>: <code>sha256-iyjrNR7nWBaRE4y4d/0ajFW8XSLc2PLKyp7oi5UJTc8= sha384-fm3Tv3I5fMaFSoRkuCHq9431bh8aBbMZqxUeK2Ddl1gNR/xKiWhAlwKvUH3UE4Tr sha512-zJtE50tnON31NkK/foqnB/QHoE+P1eRyyw/hLylDk+qkCiixa3Rqo1/36Cj7lkNHfaqgQW9uF0vncadzTHVWwA==</code></p>
    </li>
    <li>
      <p class="iRCJJeCgSXzX9ymLg1TH">for <code>ecl-ec.js</code>: <code>sha256-12rwLoYVQoH8tAhY4hP5ujCt7KV3q8mwbD2vUJLQNZw= sha384-C7XQ614XmUQLMpcA+PY6ARzb1lIQ3/23oRAJtH8aKNmpLpwlyAblJ5LgaHcqYvji sha512-3NWcC9iBbT8j5h8Au4ed5wE55i/IDyhXpRCbaVl8IEYjhnhWJhiGU1A939oCuWYiJdY3sT4BhHRGJKOVt6IyMA==</code></p>
    </li>
  </ul>
</details>
<h3 class="hP0JRBIVst5iIYxPqP2U">Optional styles</h3>
<p class="iRCJJeCgSXzX9ymLg1TH">There are several optional CSS files, located in <code>ec/styles/optional</code>, which can be included in your site on not, depending on the needs.<br><strong>These optional CSS have to be called before the main ECL CSS</strong></p>
<ul class="ByrPMdX6Jirc6n7gjlSw">
  <li><code>ecl-reset.css</code>: contains some css reset rules, mostly based on normalize.css, with a few custom additions</li>
  <li><code>ecl-ec-default.css</code>: apply ECL styling to some default HTML tags (links, buttons, table, ...). Note that this file is meant to be used in specific cases, the recommanded way to use ECL is still to add corresponding classes to HTML elements. A corresponding print css <code>ecl-ec-default-print</code> is also provided.</li>
</ul>
<details>
  <summary>SRI hashes for optional files (click to expand)</summary>
  <ul>
    <li>
      <p class="iRCJJeCgSXzX9ymLg1TH">for <code>ecl-reset.css</code>: <code>sha256-cPUMy3L4h9wyowuxz4QPTwOEN1b6cVCv9OGaauPAy0I= sha384-gF70AzWQToXLH7rj6l7wfSo0Dyaw7vVmukjSKx2Pfxc2hwixbml2cyYQ3k5b5ZPv sha512-yFOdkghA4EHwl6kkVJvNCX1P8YroisJ3xqSaSrI3oWGWdx1fRNTHSiLfhfX1zoJ5fuGb1x2teYKOFYujH43v8g==</code></p>
    </li>
    <li>
      <p class="iRCJJeCgSXzX9ymLg1TH">for <code>ecl-ec-default.css</code>: <code>sha256-JIzC26dxbCNqVQQiwX/9v+a/drHRF9wmU6FwR8XlgTo= sha384-uEo9p/lhgp/+M02/8VZUVItsPvK90xaSc+jajjLSs7PaCigjOYoL9jPFBnMnyWv7 sha512-u77F0DL9uLBtXIeCuJYJXDKUNL3qsA4S0wNL3CAPxsyCrYNqjQcJr3egekkzJPq54zKZGikNIZhOJyCpNWsptg==</code></p>
    </li>
  </ul>
</details>

The sri file is generated in scripts and then moved during the website build in dist/packages, it is correctly deployed to github as it can be seen here:
https://github.com/ec-europa/europa-component-library/releases/tag/v3-test-sri

@planctus planctus requested a review from a team April 13, 2023 13:27
@github-actions
Copy link

github-actions bot commented Apr 13, 2023

@github-actions github-actions bot temporarily deployed to pull request April 13, 2023 13:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 14, 2023 07:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 14, 2023 09:03 Inactive
Copy link
Contributor

@HAL-Patch-INNO HAL-Patch-INNO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing review_id

@github-actions github-actions bot temporarily deployed to pull request April 14, 2023 12:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 14, 2023 12:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 14, 2023 13:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 14, 2023 14:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 14, 2023 14:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 16, 2023 15:46 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 17, 2023 07:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 17, 2023 08:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 17, 2023 08:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 17, 2023 12:15 Inactive
@emeryro emeryro changed the title chore(website): Fixing getting started and typography pages chore(website): Fixing getting started and typography pages - FRONT-3925 Apr 18, 2023
@emeryro emeryro merged commit f4dc379 into v3-dev Apr 18, 2023
@emeryro emeryro deleted the chore-fixing-website-pages branch April 18, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants