feat(gallery): Component updates, new video and audio icons - FRONT-3887 #2793
Conversation
planctus
changed the title
planctus
added
process: review needed
process: business approval needed
and removed
process: WIP
labels
…brary into FRONT-3887-Gallery-updates
…d EU - FRONT-3887
…opa-component-library into FRONT-3887-Gallery-updates
…brary into FRONT-3887-Gallery-updates
…con with the text - FRONT-3887
planctus
added
process: review needed
and removed
process: business approval needed
labels
| @@ -16,6 +16,7 @@ npm install --save @ecl/twig-component-gallery | |||
| - "download" (object) (default: {}): object of type link | |||
| - "share" (object) (default: {}): object of type link | |||
| - **"items"** (array) (default: []) | |||
| - "playable" (boolean) (default: false) Activate the play icon on the thumbnail | |||
There was a problem hiding this comment.
can't we detect this is parameter video or embedded_video is filled?
There was a problem hiding this comment.
this is the current check we have:
{% if (_item.playable is not empty or _item.video is not empty or _item.embedded_video is not empty)
The parameter is meant to give the chance to manually "trigger" the play icon, could be removed in case we don't expect any use case where this would be used
There was a problem hiding this comment.
I don't really see a case where we would want to have this play icon if this is not a video.
We could keep it, but I fear that it may be confusing for users (we should at least make it clear in the comment/readme)
There was a problem hiding this comment.
it is foreseen for the audio files as well, but in the end this would still be an "embedded_video" so i think we can safely remove this parameter...
There was a problem hiding this comment.
this change of icon may affect other components or pages
we should at least highlight it in the pr description
planctus
changed the title
No description provided.