-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blockquote): use picture tag - FRONT-3873 #2784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in the inline comment, i would create a pr first for the introduction of the picture template and a separate one for the adoption in the blockquote
I will also add a test in the blockquote for the backward compatibility, i think this should always be the case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question:
I wanted to raise this in the picture pr, but then i convinced myself not to, now that i look at the blockquote it seems relevant again.
Why do we nest the img data in the picture object in the picture template?
If that is for the easyness of passing a single object, we have to consider that most of the replacements in the different components will need this deprecation while if we keep the img data separated from the picture data we are basically only extending the existing components by extending the needed data.
I find it cleaner that way: we pass the picture object, which contains everything needed to render the image. It also mimic the markup structure. |
We could flatten the structure in the picture component, having directly sources and image at root level, if that would make things better. |
Use picture tag instead of background image
Notes: