Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(media-container): Better describing the way to use the ratio parameter - FRONT-3864 #2769

Merged
merged 2 commits into from
Feb 15, 2023
Merged

fix(media-container): Better describing the way to use the ratio parameter - FRONT-3864 #2769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9a9ac0
fix(media-container): Better describing the way to use the ratio para…
planctus Feb 14, 2023
c520553
Merge branch 'v3-dev' into FRONT-3864-fix-media-container-docs
emeryro Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/implementations/twig/components/media-container/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ npm install --save @ecl/twig-component-media-container
- "label" (string) (default: ''),
- "description" (string) (default: ''),
- **"alt"** (string) (default: '') The alternate text foher the image,
- **"ratio"** (string) (default: 16-9) The ratio of the embedded media, if any,
- **"ratio"** (string) ('') Ratio of the embedded media, if empty the ratio will be set by the js
- **"extra_classes"** (optional) (string) (default: '') Extra classes (space separated)
- **"extra_attributes"** (optional) (array) (default: []) Extra attributes
- "name" (string) Attribute name, eg. 'data-test'
Expand Down
2 changes: 1 addition & 1 deletion src/implementations/twig/components/media-container/media-container.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
...
]
- "ratio" (string) (default: 16-9)
- "ratio" (string) ('')

Blocks:
- "embedded_media"
Expand Down
3 changes: 2 additions & 1 deletion src/implementations/twig/components/media-container/media-container.story.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const getArgTypes = (data) => {
argTypes.ratio = {
name: 'ratio',
type: { name: 'select' },
description: 'Media ratio',
description: 'Media ratio (if empty the ratio will be set by the js)',
options: {
auto: '',
'16/9': '16-9',
Expand All @@ -69,6 +69,7 @@ const getArgTypes = (data) => {
},
table: {
type: { summary: 'string' },
defaultValue: { summary: '' },
category: 'Display',
},
};
Expand Down