Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(js): Making destroy method in the components accessible to the autoInit, fixing cssresources behaviour #2383

Merged
merged 6 commits into from
Apr 5, 2022
Merged

chore(js): Making destroy method in the components accessible to the autoInit, fixing cssresources behaviour #2383

merged 6 commits into from
Apr 5, 2022

Conversation

planctus
Copy link
Collaborator

@planctus planctus commented Apr 4, 2022 •
edited
Loading

In this PR:

  1. The destry method of all of our components was not accessible by the autoInit(), therefore it was not working.
  2. The logic of the autoInit() is now to destroy every component and then initialise them so it can be used to update the components as well, the update method seems useless now.
  3. The problem with cssresources has been simply fixed with an onLoad, it might not be supported by IE but i don't think we care

You can check the carousel story and click to get the rtl styles correctly applied, hopefully :)

@planctus planctus requested a review from a team April 4, 2022 14:32
@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

🚀 Deployed on https://ecl-preview-2383--europa-component-library.netlify.app

@planctus planctus changed the title chore(autoInit): fixing destroy method, destroying before initialising strategy chore(js): Making destroy method in the components accessible to the autoInit, fixing cssresources behaviour Apr 5, 2022
@papegaill papegaill merged commit c1e35ce into v3-dev Apr 5, 2022
@papegaill papegaill deleted the chore-autoinit-fix branch April 5, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@planctus @papegaill