Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): Adapt JS for RTL support - FRONT-3594 #2379

Merged
merged 11 commits into from
Apr 21, 2022
Merged

Conversation

papegaill
Copy link
Contributor

@papegaill papegaill commented Apr 1, 2022

I needed to review the way to remove listeners on specific elements like so:
https://bobbyhadz.com/blog/javascript-remove-all-event-listeners-from-element

@github-actions
Copy link

github-actions bot commented Apr 1, 2022

emeryro
emeryro previously approved these changes Apr 19, 2022
Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work well. I would just request a second review by @planctus as it would impact the way we handle all javascript components

@planctus planctus merged commit fa3dddd into v3-dev Apr 21, 2022
@planctus planctus deleted the feat/FRONT-3594 branch April 21, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants