Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(message): Changing description tag to div - FRONT-3551 #2338

Merged
merged 3 commits into from
Feb 16, 2022
Merged

fix(message): Changing description tag to div - FRONT-3551 #2338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ceec41b
fix(message): Changing dfescription tag to div - front-3551
planctus Feb 15, 2022
6db903c
fix(message): Fixing closure
planctus Feb 15, 2022
1e41868
Merge branch 'v3-dev' into front-3551-message-fix
planctus Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions src/implementations/twig/components/message/__snapshots__/message.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ exports[`EC Message Error renders correctly 1`] = `
>
Error message
</div>
<p
<div
class="ecl-message__description"
>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam accumsan semper lorem, ac mollis lacus tincidunt eu. Duis scelerisque diam eu tempus fringilla.
</p>
</div>
</div>
</div>
</jest>
Expand Down Expand Up @@ -112,11 +112,11 @@ exports[`EC Message Info renders correctly 1`] = `
>
Information message
</div>
<p
<div
class="ecl-message__description"
>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam accumsan semper lorem, ac mollis lacus tincidunt eu. Duis scelerisque diam eu tempus fringilla.
</p>
</div>
</div>
</div>
</jest>
Expand Down Expand Up @@ -175,11 +175,11 @@ exports[`EC Message Info renders correctly with extra attributes 1`] = `
>
Information message
</div>
<p
<div
class="ecl-message__description"
>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam accumsan semper lorem, ac mollis lacus tincidunt eu. Duis scelerisque diam eu tempus fringilla.
</p>
</div>
</div>
</div>
</jest>
Expand Down Expand Up @@ -236,11 +236,11 @@ exports[`EC Message Info renders correctly with extra class names 1`] = `
>
Information message
</div>
<p
<div
class="ecl-message__description"
>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam accumsan semper lorem, ac mollis lacus tincidunt eu. Duis scelerisque diam eu tempus fringilla.
</p>
</div>
</div>
</div>
</jest>
Expand Down Expand Up @@ -297,11 +297,11 @@ exports[`EC Message Success renders correctly 1`] = `
>
Success message
</div>
<p
<div
class="ecl-message__description"
>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam accumsan semper lorem, ac mollis lacus tincidunt eu. Duis scelerisque diam eu tempus fringilla.
</p>
</div>
</div>
</div>
</jest>
Expand Down Expand Up @@ -358,11 +358,11 @@ exports[`EC Message Warning renders correctly 1`] = `
>
Warning message
</div>
<p
<div
class="ecl-message__description"
>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam accumsan semper lorem, ac mollis lacus tincidunt eu. Duis scelerisque diam eu tempus fringilla.
</p>
</div>
</div>
</div>
</jest>
Expand Down Expand Up @@ -419,11 +419,11 @@ exports[`EU Message Error renders correctly 1`] = `
>
Error message
</div>
<p
<div
class="ecl-message__description"
>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam accumsan semper lorem, ac mollis lacus tincidunt eu. Duis scelerisque diam eu tempus fringilla.
</p>
</div>
</div>
</div>
</jest>
Expand Down Expand Up @@ -480,11 +480,11 @@ exports[`EU Message Info renders correctly 1`] = `
>
Information message
</div>
<p
<div
class="ecl-message__description"
>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam accumsan semper lorem, ac mollis lacus tincidunt eu. Duis scelerisque diam eu tempus fringilla.
</p>
</div>
</div>
</div>
</jest>
Expand Down Expand Up @@ -543,11 +543,11 @@ exports[`EU Message Info renders correctly with extra attributes 1`] = `
>
Information message
</div>
<p
<div
class="ecl-message__description"
>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam accumsan semper lorem, ac mollis lacus tincidunt eu. Duis scelerisque diam eu tempus fringilla.
</p>
</div>
</div>
</div>
</jest>
Expand Down Expand Up @@ -604,11 +604,11 @@ exports[`EU Message Info renders correctly with extra class names 1`] = `
>
Information message
</div>
<p
<div
class="ecl-message__description"
>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam accumsan semper lorem, ac mollis lacus tincidunt eu. Duis scelerisque diam eu tempus fringilla.
</p>
</div>
</div>
</div>
</jest>
Expand Down Expand Up @@ -665,11 +665,11 @@ exports[`EU Message Success renders correctly 1`] = `
>
Success message
</div>
<p
<div
class="ecl-message__description"
>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam accumsan semper lorem, ac mollis lacus tincidunt eu. Duis scelerisque diam eu tempus fringilla.
</p>
</div>
</div>
</div>
</jest>
Expand Down Expand Up @@ -726,11 +726,11 @@ exports[`EU Message Warning renders correctly 1`] = `
>
Warning message
</div>
<p
<div
class="ecl-message__description"
>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam accumsan semper lorem, ac mollis lacus tincidunt eu. Duis scelerisque diam eu tempus fringilla.
</p>
</div>
</div>
</div>
</jest>
Expand Down
2 changes: 1 addition & 1 deletion src/implementations/twig/components/message/message.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
}) only %}

<div class="ecl-message__title">{{ _title }}</div>
<p class="ecl-message__description">{{ _description }}</p>
<div class="ecl-message__description">{{ _description }}</div>
</div>
</div>

Expand Down
8 changes: 4 additions & 4 deletions src/implementations/twig/compositions/etrans/__snapshots__/etrans.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ exports[`eTrans EC renders correctly with languages list 1`] = `
>
This page is not available in [language]
</div>
<p
<div
class="ecl-message__description"
/>
</div>
Expand Down Expand Up @@ -441,7 +441,7 @@ exports[`eTrans EC renders correctly without languages list 1`] = `
>
Page language unavailable
</div>
<p
<div
class="ecl-message__description"
/>
</div>
Expand Down Expand Up @@ -527,7 +527,7 @@ exports[`eTrans EU renders correctly with languages list 1`] = `
>
This page is not available in [language]
</div>
<p
<div
class="ecl-message__description"
/>
</div>
Expand Down Expand Up @@ -904,7 +904,7 @@ exports[`eTrans EU renders correctly without languages list 1`] = `
>
Page language unavailable
</div>
<p
<div
class="ecl-message__description"
/>
</div>
Expand Down