Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(site-header): Correctly rename the cta class in the standardised variant - FRONT-3519 #2292

Merged
merged 7 commits into from
Dec 21, 2021
Merged

fix(site-header): Correctly rename the cta class in the standardised variant - FRONT-3519 #2292

merged 7 commits into from
Dec 21, 2021

Conversation

papegaill
Copy link
Contributor

@papegaill papegaill commented Dec 20, 2021 •
edited
Loading

CSS assets limit increased by 1kb

@papegaill papegaill requested a review from a team December 20, 2021 13:23
@github-actions
Copy link

github-actions bot commented Dec 20, 2021 •
edited
Loading

🚀 Deployed on https://ecl-preview-2292--europa-component-library.netlify.app

emeryro
emeryro requested changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avoid breaking changes, I suggest to keep also the previous class name in the css, and mark it as deprecated.
We could remove it when we do the revamp of the component next year

@emeryro emeryro merged commit b45af6d into v3-dev Dec 21, 2021
@emeryro emeryro deleted the fix/FRONT-3519 branch December 21, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emeryro emeryro emeryro approved these changes

Assignees
No one assigned
Labels
tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@papegaill @emeryro