Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(menu): allows more menu items - FRONT-3354 #2253

Merged
merged 9 commits into from
Dec 8, 2021
Merged

feat(menu): allows more menu items - FRONT-3354 #2253

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5280ec4
flexible columns
emeryro Nov 8, 2021
029f1a5
fix focus
emeryro Nov 8, 2021
504f8c3
Merge branch 'v3-dev' into FRONT-3354-menu
emeryro Nov 16, 2021
b7a2e0d
fix css, improve accessibility
emeryro Nov 17, 2021
817434e
fix js, update test
emeryro Nov 17, 2021
b8364cd
small css fix
emeryro Nov 22, 2021
0f5d80f
fix mobile css
emeryro Nov 22, 2021
1a17ada
Merge branch 'v3-dev' into FRONT-3354-menu
emeryro Nov 22, 2021
e047ad3
Merge branch 'v3-dev' into FRONT-3354-menu
emeryro Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
576 changes: 576 additions & 0 deletions src/implementations/twig/components/menu/__snapshots__/menu.test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/implementations/twig/components/menu/menu-item.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
{% endif %}

{% if item.children is defined and item.children is not empty and item.children is iterable %}
{% set _menu_list_item_attributes = _menu_list_item_attributes ~ ' data-ecl-has-children' %}
{% set _menu_list_item_attributes = _menu_list_item_attributes ~ ' data-ecl-has-children aria-haspopup aria-expanded="false"' %}
{% set _menu_list_item_class = _menu_list_item_class ~ ' ecl-menu__item--has-children' %}
{% endif %}

Expand Down
Loading