feat(site-header): add optional CTA - FRONT-2514 #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeryro
added
process: business approval needed
process: review needed
and removed
process: WIP
labels
planctus
reviewed
Sep 17, 2021
| cta_link: { | ||
| name: 'call to action', | ||
| type: { name: 'boolean' }, | ||
| defaultValue: false, |
There was a problem hiding this comment.
this defaultValue is not needed, we now set it via the getArgs() which you did, so you can remove it here .. ;)
planctus
reviewed
Sep 17, 2021
| argTypes.cta_link = { | ||
| name: 'call to action', | ||
| type: { name: 'boolean' }, | ||
| defaultValue: false, |
There was a problem hiding this comment.
Same as before, the object we build in getArgs() is replacing the defaultValue for each control as we were used to set them.
planctus
requested changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional call-to-action link to standardised site header
This is done in two phases: