Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): Fixing optional css loading in EC and EU - FRONT-2792 #2175

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

planctus
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 13, 2021

@emeryro emeryro changed the title fix(playground): Fixing optional css loading in EC and EU fix(playground): Fixing optional css loading in EC and EU - FRONT-2792 Aug 16, 2021
@emeryro
Copy link
Contributor

emeryro commented Aug 16, 2021

It works fine on netlify, but on production only the print css checkbox, in CSS resources, seems to do something (at least the 404 errors are fixed indeed).
Do you have the same behavior on your side?

@planctus
Copy link
Collaborator Author

@emeryro, wow, yes, it's a total mess...but it's not because of these recent deployments, i've checked in many "archived" versions and still the behavior of css resources is kind of erratic, the main css cannot be disabled while the print works as expected.
If this was not the case before the migration to the asset manager then it's something related to that, otherwise we have been living with this issue for a very long time, i don't know...

@planctus
Copy link
Collaborator Author

planctus commented Aug 16, 2021

I write here like to take notes:
the misbehaviour seems to be indeed the presence of two to the same css, but it seems to only occur in the archived packages.
The guess would then be that this is due to the function and the if that we use to identify the "open canvas in new tab" use case to be able to load the css because cssresources would not, when in an archived package (subfolder), i've checked in both instances, archived and production, the code we have seems to work consistently...

There is an additional confusion due to the fact that in v2 we load in the "open canvas in new tab" a different set of css resources from the ones we have loaded in the iframe, in one case is the website-legacy preset while in the second is the website preset.
In any case the i

@emeryro emeryro merged commit 89c1b2d into v3-dev Aug 17, 2021
@emeryro emeryro deleted the fix/FRONT-2792-Fixing-optional-css-loading branch August 17, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants