Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typography): update EU typography #2139

Merged
merged 7 commits into from
Jul 8, 2021
Merged

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Jun 30, 2021

@emeryro emeryro self-assigned this Jun 30, 2021
@emeryro emeryro requested a review from a team June 30, 2021 13:24
@github-actions
Copy link

github-actions bot commented Jun 30, 2021

@emeryro emeryro removed their assignment Jun 30, 2021
Copy link
Collaborator

@planctus planctus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems all good to me, there is just a small difference in the "specs", which is:
The exception to this rule are headings, the thing is that the same text appears also in the EC guildelines, so i don't know, if we have to change it here it should change also there...
The other thing i noticed is that from the "usage" page in EU all the links to the guidelines are pointing to EC, maybe we can fix this in this pr.. ;)

@emeryro
Copy link
Contributor Author

emeryro commented Jul 8, 2021

I fixed every fault link that I found in usage pages
Also, I created https://citnet.tech.ec.europa.eu/CITnet/jira/browse/FRONT-2424 to update "getting started" pages

@planctus planctus merged commit 37453bb into v3-dev Jul 8, 2021
@planctus planctus deleted the FRONT-2372-eu-typography branch July 8, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants