Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utilities): improve dimension utilities (ECL2) - FRONT-2196 #2047

Merged
merged 2 commits into from
Apr 28, 2021
Merged

feat(utilities): improve dimension utilities (ECL2) - FRONT-2196 #2047

merged 2 commits into from
Apr 28, 2021

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Apr 28, 2021 •
edited
Loading

  • add max-width:100% to images inside ecl-editor
  • add new utilities to manage max-width and max-height (part of the 'dimension' utilities)
  • fix utilities files for dimension and display (they were inverted in file system)

preview: https://ecl-preview-2047--europa-component-library.netlify.app/ec/utilities/dimension/usage/

@emeryro emeryro self-assigned this Apr 28, 2021
@emeryro emeryro requested a review from a team April 28, 2021 07:30
@emeryro emeryro changed the title improve dimension utilities feat(utilities): improve dimension utilities - FRONT-2196 Apr 28, 2021
@github-actions
Copy link

github-actions bot commented Apr 28, 2021 •
edited
Loading

🚀 Deployed on https://ecl-preview-2047--europa-component-library.netlify.app

@emeryro emeryro removed their assignment Apr 28, 2021
@emeryro emeryro changed the title feat(utilities): improve dimension utilities - FRONT-2196 feat(utilities): improve dimension utilities (ECL2) - FRONT-2196 Apr 28, 2021
@papegaill papegaill merged commit bc5e019 into v2-dev Apr 28, 2021
@papegaill papegaill deleted the FRONT-2196-image-width branch April 28, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papegaill papegaill papegaill approved these changes

Assignees
No one assigned
Labels
tag: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emeryro @papegaill