Skip to content

Commit

Permalink
fix(media-container): Better describing the way to use the ratio para…
Browse files Browse the repository at this point in the history
…meter - FRONT-3864 (#2769)

Co-authored-by: Romain Emery <emery.romain@gmail.com>
  • Loading branch information
planctus and emeryro authored Feb 15, 2023
1 parent c690fc6 commit b3a9990
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ npm install --save @ecl/twig-component-media-container
- "label" (string) (default: ''),
- "description" (string) (default: ''),
- **"alt"** (string) (default: '') The alternate text foher the image,
- **"ratio"** (string) (default: 16-9) The ratio of the embedded media, if any,
- **"ratio"** (string) ('') Ratio of the embedded media, if empty the ratio will be set by the js
- **"extra_classes"** (optional) (string) (default: '') Extra classes (space separated)
- **"extra_attributes"** (optional) (array) (default: []) Extra attributes
- "name" (string) Attribute name, eg. 'data-test'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
...
]
- "ratio" (string) (default: 16-9)
- "ratio" (string) ('')
Blocks:
- "embedded_media"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const getArgTypes = (data) => {
argTypes.ratio = {
name: 'ratio',
type: { name: 'select' },
description: 'Media ratio',
description: 'Media ratio (if empty the ratio will be set by the js)',
options: {
auto: '',
'16/9': '16-9',
Expand All @@ -69,6 +69,7 @@ const getArgTypes = (data) => {
},
table: {
type: { summary: 'string' },
defaultValue: { summary: '' },
category: 'Display',
},
};
Expand Down

1 comment on commit b3a9990

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.