Skip to content

Commit

Permalink
underline (#3545)
Browse files Browse the repository at this point in the history
  • Loading branch information
emeryro authored Aug 7, 2024
1 parent 24a5956 commit 55cd8ef
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 6 deletions.
4 changes: 0 additions & 4 deletions src/implementations/vanilla/components/banner/banner.scss
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ $banner: null !default;
display: block;
font: map.get($banner, 'font', 'title', 'mobile');
margin: 0;
text-underline-offset: var(--s-2xs);

&:hover {
color: map.get($banner, 'text-color', 'dark');
Expand Down Expand Up @@ -233,7 +232,6 @@ $banner: null !default;
.ecl-banner__title,
.ecl-banner__title-link {
font: map.get($banner, 'font', 'title', 'tablet');
text-underline-offset: var(--s-xs);
}

.ecl-banner__description,
Expand Down Expand Up @@ -293,11 +291,9 @@ $banner: null !default;
.ecl-banner__title-link {
display: inline;
font: map.get($banner, 'font', 'title', 'desktop-m');
text-underline-offset: var(--s-2xs);

.ecl-banner--font-l & {
font: map.get($banner, 'font', 'title', 'desktop-l');
text-underline-offset: var(--s-xs);
}

.ecl-banner--color-light & {
Expand Down
1 change: 1 addition & 0 deletions src/implementations/vanilla/components/link/link.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ $min-width: 44px; // According to COMM every interactive element should be at le
font-family: var(--ff-d);
margin: 0;
text-decoration: underline;
text-underline-offset: 5px;

&:visited {
color: map.get($link, 'color-visited');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,6 @@ $mega-menu: null !default;

&:hover {
text-decoration: underline !important;
text-underline-offset: var(--s-2xs);
}

&:focus-visible {
Expand Down Expand Up @@ -1165,7 +1164,6 @@ $mega-menu: null !default;

&:hover {
text-decoration: underline;
text-underline-offset: var(--s-2xs);
}
}

Expand Down
1 change: 1 addition & 0 deletions src/implementations/vanilla/components/tag/tag.scss
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ $tag: null !default;
padding: map.get($tag, 'padding');
text-align: left;
text-decoration: underline;
text-underline-offset: 5px;

&:focus-visible {
background-color: map.get($tag, 'background-color-focus');
Expand Down

1 comment on commit 55cd8ef

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.