Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): improve workflows - EUBFR-228 #183

Merged
merged 4 commits into from
Jan 16, 2019

Conversation

kalinchernev
Copy link
Contributor

PR description

ECL has changed through time comparing the main repository, though the CLI arguments suggested in EUBFR-228 are still valid.

Test guidelines

Not required, but could be useful:

  1. Remove the following and commit temporarily:
    "publish": {
      "allowBranch": "master"
    }

This will allow you to test the command even if you're not on master branch.

  1. Run the publish script following the existing guides

Validate that lerna increments packages' versions correctly both in package.json files, as well as lerna.json which holds the version number centrally. For instance "version": "0.5.0" will become "version": "0.5.1".

  1. Use git reset HEAD~ and then git reset --hard to remove your temporary commit and changes allowing you to test out of master branch.

  2. Test the change log generation

Get personal access token from Github

Follow the following guide.

Export your github token for the current terminal session

$ export GITHUB_AUTH=your token...

Run the changelog script

$ yarn changelog

@MrGRA MrGRA self-requested a review January 15, 2019 13:26
@MrGRA MrGRA self-assigned this Jan 15, 2019
Copy link
Collaborator

@MrGRA MrGRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kalinchernev, it took me a while to understand the change from ignore to ingoreFiles in lerna.json, I spent some time reading the Lerna documentation.

I din't run the yarn publish (publish sounds dangerous)
After exporting the GITHUB_AUTH after a new token I tested the yarn changelog and it looks good.

yarn_changelog

@kalinchernev
Copy link
Contributor Author

kalinchernev commented Jan 15, 2019

@MrGRA thanks for testing this one!
Don't worry about testing the publish command, it's not actually going to do anything to the outside world out of the project. Steps 1-3 are showing an example, the only specific part is managing git history locally, which is safe if you don't push to remote :)
Nice terminal theme!

@kalinchernev kalinchernev merged commit a1fc4bd into master Jan 16, 2019
@kalinchernev kalinchernev deleted the chore/improve-release-workflows-EUBFR-228 branch January 16, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants