Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(etl): correct type field in BUDG ETL - EUBFR-220 #170

Merged
merged 5 commits into from
Nov 12, 2018
Merged

fix(etl): correct type field in BUDG ETL - EUBFR-220 #170

merged 5 commits into from
Nov 12, 2018

Conversation

MrGRA
Copy link
Collaborator

@MrGRA MrGRA commented Nov 9, 2018 •
edited
Loading

PR description

Fix Creative Europe coming from BUDG/XLS producer "type" field

PR overview:

  • Change the value of the "type" field from "type": [""] to "type": []
  • Refactor all the variables calling to functions

@kalinchernev kalinchernev changed the title fix(etl): fix ETL BUDG- EUBFR-220 fix(etl): correct type field in BUDG ETL - EUBFR-220 Nov 12, 2018
@kalinchernev kalinchernev self-assigned this Nov 12, 2018
kalinchernev
kalinchernev suggested changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@kalinchernev kalinchernev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are ok, please only re-generate documentation for the ETL with yarn docs:md and submit these changes.
Thanks!

@kalinchernev kalinchernev merged commit 7a25808 into master Nov 12, 2018
@kalinchernev kalinchernev deleted the fix/improve-budg-xls-etl-EUBFR-220 branch November 12, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalinchernev kalinchernev kalinchernev approved these changes

Assignees

@kalinchernev kalinchernev

Labels
tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrGRA @kalinchernev