Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(budgetFormatter): ignore spaces between when abbreviations - EUBFR-214 #166

Merged
merged 20 commits into from
Dec 12, 2018
Merged

refactor(budgetFormatter): ignore spaces between when abbreviations - EUBFR-214 #166

merged 20 commits into from
Dec 12, 2018

Conversation

kalinchernev
Copy link
Contributor

PR description

Tests added contain the main idea.

QA Checklist

When you add a new ETL/producer, please check for the following:

  • Producer's secrets are stored safely
  • Ensure the ETL is added to the corresponding scripts/ for automated deployment and deletion
  • There is at least 1 unit test with a jest snapshot for the transform function of the ETL
  • Update the file PRODUCERS_DATA_AVAILABILITY_GRID.md indicating which fields are available in source data of ETL
  • Ensure there is (flow/jsdocs) documentation in the tranform.js file which is to be used for automated documentation
  • Generate the necessary documentation pages for the new ETL by yarn docs:md

@kalinchernev kalinchernev requested a review from a team October 12, 2018 08:28
@degliwe degliwe self-assigned this Oct 23, 2018
degliwe
degliwe reviewed Nov 27, 2018
View reviewed changes
lib/budget/getCurrency.js Outdated Show resolved Hide resolved
lib/budget/getCurrency.js Outdated Show resolved Hide resolved
lib/budget/getCurrencyData.js Outdated Show resolved Hide resolved
degliwe and others added 7 commits November 27, 2018 11:05
@degliwe @kalinchernev
Update lib/budget/getCurrency.js
2f80e61 
Co-Authored-By: kalinchernev <kalinchernev@users.noreply.github.com>
@degliwe @kalinchernev
Update lib/budget/getCurrency.js
c9876ee 
Co-Authored-By: kalinchernev <kalinchernev@users.noreply.github.com>
@degliwe @kalinchernev
Update lib/budget/getCurrencyData.js
3465858 
Co-Authored-By: kalinchernev <kalinchernev@users.noreply.github.com>
@kalinchernev
Merge branch 'master' into refactor/eubfr-lib-EUBFR-214
0406f9f
@kalinchernev
Update to latest master
dab672d
@kalinchernev
Merge branch 'master' of github.com:ec-europa/eubfr-data-lake into re…
f26dcb1 
…factor/eubfr-lib-EUBFR-214
@yhuard
Merge branch 'master' into refactor/eubfr-lib-EUBFR-214
7851718
@yhuard yhuard assigned yhuard and unassigned degliwe Dec 11, 2018
@yhuard yhuard removed their assignment Dec 12, 2018
@yhuard yhuard merged commit 058ce87 into master Dec 12, 2018
@yhuard yhuard deleted the refactor/eubfr-lib-EUBFR-214 branch December 12, 2018 07:05
@yhuard yhuard mentioned this pull request Dec 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@degliwe degliwe degliwe left review comments

@yhuard yhuard yhuard approved these changes

Assignees
No one assigned
Labels
tag: breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalinchernev @degliwe @yhuard