Update to JUCE 6.1.5 #171
Update to JUCE 6.1.5 #171
Conversation
rsjbailey
force-pushed
the
update-juce-6_1_5
branch
from
6726b42
to
b3bb0b7
Compare
| String("Cannot delete last programme"), | ||
| "The Scene must always have at least one programme.", false); | ||
| "The Scene must always have at least one programme.", nullptr); |
There was a problem hiding this comment.
Where does the box pop up if the associated component is nullptr? If it stays within the plug-in window then no problem, but if it could be anywhere, it might be missed by the user.
There was a problem hiding this comment.
Well anecdotally, it pops up over the plugin window. But yes, good point. I'll go check the docs :)
|
closes #174 |
| + add_compile_options($<$<CONFIG:Release,RelWithDebInfo,MinSizeRel>:/Ot>) # Favor Size Or Speed (Favor fast code) | ||
| + add_compile_options($<$<CONFIG:Release,RelWithDebInfo,MinSizeRel>:/GF>) # Enable String Pooling | ||
| + add_compile_options($<$<CONFIG:Release,RelWithDebInfo,MinSizeRel>:/EHa>) # Enable C++ Exceptions | ||
| + add_compile_options($<$<CONFIG:Release,RelWithDebInfo,MinSizeRel>:/Oy>) # Omit Frame Pointers |
There was a problem hiding this comment.
Might want to keep frame pointers on RelWithDebInfo as it gives you better stack traces.
There was a problem hiding this comment.
Also the favour size or speed should be set to size for MinSizeRel
| - "$<$<CONFIG:Release>:${TARGET_DESTINATION_RELEASE}>" | ||
| + "$<$<CONFIG:Release,RelWithDebInfo,MinSizeRel>:${TARGET_DESTINATION_RELEASE}>" |
There was a problem hiding this comment.
Probably not an issue as I don't think we actually hit this code, but should we have different target destinations for the different configs here?
rsjbailey
force-pushed
the
update-juce-6_1_5
branch
2 times, most recently
from
f954c8e
to
afe45dc
Compare
* Updated JUCE submodule * Update license for JUCE 6 * Include VST3 sdk as subproject * Add VST sdk target to imported JUCE::VST3 target * Patch VST3 SDK to add missing cmake configs * Patch VST3 SDK to remove ide folder modification * Add newly required macos frameworks to JUCE::core target * Change NativeMessageBox useages to reflect JUCE API changes * Reorder some headers to avoid issues with imported juce namespace (see issue #140) * Add /bigobj flag on windows to prevent build errors
rsjbailey
force-pushed
the
update-juce-6_1_5
branch
from
afe45dc
to
2ac0509
Compare
Update to Juce 6.1.5 to fix a bug with key handling under macos/arm64
using namespace juceand juce module headers from generated JuceHeader.h #140)