-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 96 - Reword and improve routing options #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firthm01
changed the title
96 reword and improve routing options
Fix 96 - Reword and improve routing options
Aug 19, 2021
firthm01
added a commit
to marthellio/ear-production-suite
that referenced
this pull request
Aug 19, 2021
rsjbailey
reviewed
Aug 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just added a couple of comments to be awkward
ear-production-suite-plugins/plugins/direct_speakers/src/channel_gains_box.hpp
Outdated
Show resolved
Hide resolved
ear-production-suite-plugins/plugins/direct_speakers/src/direct_speakers_frontend_connector.cpp
Outdated
Show resolved
Hide resolved
ear-production-suite-plugins/plugins/direct_speakers/src/direct_speakers_plugin_editor.cpp
Outdated
Show resolved
Hide resolved
rsjbailey
reviewed
Aug 26, 2021
ear-production-suite-plugins/plugins/direct_speakers/src/channel_gains_box.hpp
Outdated
Show resolved
Hide resolved
firthm01
added a commit
to marthellio/ear-production-suite
that referenced
this pull request
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewords "enter receiving channel" to make more clear (it's the Scenes receiving channel) - ensure new text fits correctly.
Show a single channel rather than channel ranges for single channel inputs (objects or mono DS)
Closes #96