Fix 99 - Metadata always reported as changed #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...Otherwise you enact nothing. BREAKS UI! This reveals an underlying UI bug in that it is now impossible to check the checkboxes in the Add Item dialog.
Checked state should remain as the user left it.
Otherwise the old flag state still exists in the sceneStore
rsjbailey
reviewed
Aug 20, 2021
ear-production-suite-plugins/lib/src/communication/direct_speakers_metadata_sender.cpp
Outdated
Show resolved
Hide resolved
This creates a race condition where we might set false AFTER new data has come in (which in turn wouldn't get processed). Instead set false immediately after generating the message, then set back true if send fails. If data has changed in the meantime, then that's also fine - it should be true for that case too anyway.
.. since it will be copied anyway
firthm01
added a commit
to marthellio/ear-production-suite
that referenced
this pull request
Sep 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. even when not. Flag never reset.
Closes #99