Closed
Conversation
…tions post-boot. - Start with bundled - Next, load from disk - Finally, should query live (not done yet)
- Fixed error caused by fetchLatestSchema stub not including valid keys - Changed getMergedEcosystemPath to be more viable - Enabled updateLatestMergedEcosystemSchema call in GameSelectionScreen
- Also removed EcosystemSchema class as no longer needed - Replaced usages of EcosystemSchema getters with reactive equivalents.
Fetches the latest schema from the API on game selection. 12 hour refresh window, can be tuned / removed based on needs. This uses the 304 response of the API to determine if the remote version has been updated since the last request. Not a huge difference in performance locally but it is more efficient on our end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetches the latest schema from the API on game selection with a 12 hour refresh window (can be tuned or removed if not necessary). Schema is cached locally and update requests make proper use of the 304 response to avoid pulling the schema when it hasnt been updated.
Depends on #2113