Conversation
The custom installation method tracks intallations in a state file. Use the existing state-based methods to uninstall and disable/enable mods. This subtly changes the old behaviour since uninstallSubDir and applyModeSubDirs are no longer called like they were in the implementation that resided in GenericProfileInstaller. I assume it's safe to ignore this change and that the state-based methods contain all the logic required for mods installed with addToStateFile. It's out of the current scope to figure out if lovely actually needs a custom plugin installer or if it would do just fine with the InstallRulePluginInstaller, which has evolved since support for Lovely as introduced.
ebkr
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom installation method tracks intallations in a state file. Use the existing state-based methods to uninstall and disable/enable mods.
This subtly changes the old behaviour since uninstallSubDir and applyModeSubDirs are no longer called like they were in the implementation that resided in GenericProfileInstaller. I assume it's safe to ignore this change and that the state-based methods contain all the logic required for mods installed with addToStateFile.
It's out of the current scope to figure out if lovely actually needs a custom plugin installer or if it would do just fine with the InstallRulePluginInstaller, which has evolved since support for Lovely as introduced.