You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The wrapper scripts are mangling any arguments with spaces and passing them on as multiple arguments. This is known to cause any game installed to a path with a space in it to fail to launch. Improper argument parsing can be a serious issue and this could cause additional bugs in the future if not fixed.
This preserves the arguments while only striping out the options the wrapper script is checking for. The start_game_bepinex.sh script may also need to be updated and I'm working with the BepInExPack for Valheim team on this. I don't know what other games use a start_game_bepinex.sh script and if they would need updated too.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
I agree to the following terms with @ebkr for the contents of this pull request.
You grant to "ebkr" a perpetual, non-exclusive, irrevocable, worldwide, royalty-free, transferable license (with the power to sub-license) of all of your relevant intellectual property rights (including copyright, patent, and any other rights) for any purpose, including: to use, copy, make available to the public, prepare derivative works of, distribute and publicly perform. It also includes the right to license the Contributions to others without any restriction on the nature of the sub-licence, including without limitation: (a) open source licenses like the AGPL license; and (b) binary, proprietary, or commercial licenses. Except for the license you have granted to us in this agreement, you reserve all other rights you possess in the Contribution.
You are able to grant us these rights. You represent that you are legally entitled to grant the above licence. For example, if your employer has rights to intellectual property that you create, you represent that your employer has given you authority to license the Contributions to us under the licence described in the previous paragraph, or that your employer has waived the rights you have licensed to us in the Contributions.
The Contributions are your original work. You represent that the Contributions are your original works of authorship, and to your knowledge, no other person claims, or has the right to claim, any right in any invention or patent related to the Contributions. You also represent that you are otherwise free to enter into this agreement with us. For example, if you have signed an agreement requiring you to assign the intellectual property rights in the Contributions to an employer or customer, that would conflict with the terms of this agreement, unless they gave you appropriate permission.
We determine the code that is in our project. You understand that the decision to include the Contribution in any project or source repository is entirely that of "ebkr", and this agreement does not guarantee that the Contributions will be included in any product.
No Implied Warranties. "ebkr" acknowledges that, except as explicitly described in this agreement, you have provided the Contribution on an "as is" basis, without warranties as to merchantability, or fitness for a particular purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrapper scripts are mangling any arguments with spaces and passing them on as multiple arguments. This is known to cause any game installed to a path with a space in it to fail to launch. Improper argument parsing can be a serious issue and this could cause additional bugs in the future if not fixed.
This preserves the arguments while only striping out the options the wrapper script is checking for. The start_game_bepinex.sh script may also need to be updated and I'm working with the BepInExPack for Valheim team on this. I don't know what other games use a start_game_bepinex.sh script and if they would need updated too.