Skip to content

Comments

Fix posix scripts to preserve arguments with spaces#1843

Merged
ebkr merged 1 commit intoebkr:developfrom
arrowmaster:linuxwrapper
Aug 13, 2025
Merged

Fix posix scripts to preserve arguments with spaces#1843
ebkr merged 1 commit intoebkr:developfrom
arrowmaster:linuxwrapper

Conversation

@arrowmaster
Copy link
Contributor

The wrapper scripts are mangling any arguments with spaces and passing them on as multiple arguments. This is known to cause any game installed to a path with a space in it to fail to launch. Improper argument parsing can be a serious issue and this could cause additional bugs in the future if not fixed.

This preserves the arguments while only striping out the options the wrapper script is checking for. The start_game_bepinex.sh script may also need to be updated and I'm working with the BepInExPack for Valheim team on this. I don't know what other games use a start_game_bepinex.sh script and if they would need updated too.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@arrowmaster
Copy link
Contributor Author

I agree to the following terms with @ebkr for the contents of this pull request.

You grant to "ebkr" a perpetual, non-exclusive, irrevocable, worldwide, royalty-free, transferable license (with the power to sub-license) of all of your relevant intellectual property rights (including copyright, patent, and any other rights) for any purpose, including: to use, copy, make available to the public, prepare derivative works of, distribute and publicly perform. It also includes the right to license the Contributions to others without any restriction on the nature of the sub-licence, including without limitation: (a) open source licenses like the AGPL license; and (b) binary, proprietary, or commercial licenses. Except for the license you have granted to us in this agreement, you reserve all other rights you possess in the Contribution.

You are able to grant us these rights. You represent that you are legally entitled to grant the above licence. For example, if your employer has rights to intellectual property that you create, you represent that your employer has given you authority to license the Contributions to us under the licence described in the previous paragraph, or that your employer has waived the rights you have licensed to us in the Contributions.

The Contributions are your original work. You represent that the Contributions are your original works of authorship, and to your knowledge, no other person claims, or has the right to claim, any right in any invention or patent related to the Contributions. You also represent that you are otherwise free to enter into this agreement with us. For example, if you have signed an agreement requiring you to assign the intellectual property rights in the Contributions to an employer or customer, that would conflict with the terms of this agreement, unless they gave you appropriate permission.

We determine the code that is in our project. You understand that the decision to include the Contribution in any project or source repository is entirely that of "ebkr", and this agreement does not guarantee that the Contributions will be included in any product.

No Implied Warranties. "ebkr" acknowledges that, except as explicitly described in this agreement, you have provided the Contribution on an "as is" basis, without warranties as to merchantability, or fitness for a particular purpose.

@ebkr
Copy link
Owner

ebkr commented Aug 13, 2025

As discussed, the comment above agrees to the CLA. I've taken a screenshot to keep a record of it.

image

@ebkr ebkr merged commit 8b8a8ca into ebkr:develop Aug 13, 2025
1 check was pending
@ebkr
Copy link
Owner

ebkr commented Aug 13, 2025

Thanks for the PR - All tested and working as expected on a profile with and without spaces!

@arrowmaster arrowmaster deleted the linuxwrapper branch August 30, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants