Change the icon paths used when reading a mod list from mods.yml #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old implementation had a comment mentioning BepInEx icon can be read only from the cache, yet the code immediately tried to read it from another location. Based on a sampling on 10 BepInEx games, none actually contained the icon in the path that was used. To simplify things, try to read the icon from the default location used by BepInEx plugins, and fall back to reading the icon from cache. This still isn't ideal, since cleaning the cache (by manually deleting the contents) breaks all icons relying on the cache, but fixing this to support all possible mod loaders is more than I'm willing to tackle right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation had a comment mentioning BepInEx icon can be
read only from the cache, yet the code immediately tried to read it
from another location. Based on a sampling on 10 BepInEx games, none
actually contained the icon in the path that was used.
To simplify things, try to read the icon from the default location used
by BepInEx plugins, and fall back to reading the icon from cache. This
still isn't ideal, since cleaning the cache (by manually deleting the
contents) breaks all icons relying on the cache, but fixing this to
support all possible mod loaders is more than I'm willing to tackle
right now.