Refactor download provider's downloadImportedMods to work with less callbacks #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThunderstoreDownloadProvider.downloadImportedMods: - Drop completedCallback argument and return the comboList on success instead - Rename callback argument to totalProgressCallback for clarity's sake and simplify it's signature. The other params are no longer needed since the errors aren't handled via the callback anymore BetterThunderstoreDownloader - Throw errors instead of reporting them via the callback system. While this is now inconsistent with other parts of the code base, the simplified error handling is deemed good enough reason to do so this simplifies the error handling on call site - Define singleModProcessCallback internally. This also fixed an off-by-one (mod) in the progress percentage calculation, and doesn't mark a mod fully processed when it's downloaded, but only when it's also saved to disk - The mods are now downloaded and saved using the internal helper methods instead of public downloadAndSave method which was previously called via public queueDownloadDependencies. The new functionality should be otherwise identical to downloadAndSave, except the steps can be awaited separately instead of relying on a callback to save the mod to disk ImportProfileModal.vue - Use the refactored downloadImportedProfileMods - Expect errors to be thrown and handle them accordingly - Drop downloadProgressCallback since a simple oneliner will do now - Change downloadCompletedCallback to not use callbacks of its own
VilppeRiskidev
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.