Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImportProfileModal improvements #1459

Merged
merged 3 commits into from
Oct 2, 2024
Merged

ImportProfileModal improvements #1459

merged 3 commits into from
Oct 2, 2024

Conversation

VilppeRiskidev
Copy link
Collaborator

No description provided.

@VilppeRiskidev VilppeRiskidev self-assigned this Oct 1, 2024
@VilppeRiskidev VilppeRiskidev force-pushed the import-modal-refactoring-continued branch from d35463d to 2ff3703 Compare October 1, 2024 09:46
@VilppeRiskidev VilppeRiskidev changed the title Fix showing correct modal when a file is being selected while importing profiles ImportProfileModal improvements Oct 1, 2024
anttimaki
anttimaki requested changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Overall looks nice
  • With "better safe than sorry" sentiment, I think we shouldn't use the setImmediate
  • Also note the separate question about closing the modal

src/components/profiles-modals/ImportProfileModal.vue Outdated Show resolved Hide resolved
src/components/profiles-modals/ImportProfileModal.vue Show resolved Hide resolved
@VilppeRiskidev VilppeRiskidev force-pushed the import-modal-refactoring-continued branch from c3cd5f7 to 574918b Compare October 2, 2024 08:37
@VilppeRiskidev VilppeRiskidev force-pushed the import-modal-refactoring-continued branch from 574918b to 413acb8 Compare October 2, 2024 09:06
anttimaki
anttimaki approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@anttimaki anttimaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would've been cleaner if the fixes to the first and second commit would've been done to those commits, or a separate commit, instead of bundling them into the third commit. Doesn't change the outcome though.

@anttimaki anttimaki merged commit 4ce5ede into develop Oct 2, 2024
5 checks passed
@anttimaki anttimaki deleted the import-modal-refactoring-continued branch October 2, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttimaki anttimaki anttimaki approved these changes

Assignees

@VilppeRiskidev VilppeRiskidev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VilppeRiskidev @anttimaki