Harden chunked package list API requests against CDN problems #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thunderstore's main CDN regularly just fails to respond to requests. Now that package list chunks are downloaded from the CDN, the issue also affects this part of the program. While the only real fix is to migrate to more reliable service provider, ETA on that is unknown. Meanwhile do what can be done to mitigate the issue. - Increase the number of retries and reduce the interval between them when loading the index chunk. Sometimes spamming the same request makes the CDN "wake up" and serve the file - Add "preferred CDN" query parameter to index chunk request. If the Thunderstore API endpoint supports the received value, it will uses that CDN when returning the redirect response. Intercepting the redirect response to manipulate the redirect URL in the browser environment has proven hacky in the past and is avoided here - Change the CDN on the fly on client when requesting the package list chunks. Since these request point directly to the CDN rather than Thunderstore API, manipulating them directly is feasible.
VilppeRiskidev
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thunderstore's main CDN regularly just fails to respond to requests. Now that package list chunks are downloaded from the CDN, the issue also affects this part of the program. While the only real fix is to migrate to more reliable service provider, ETA on that is unknown. Meanwhile do what can be done to mitigate the issue.