Use new Thunderstore API to fetch community's package list #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttimaki
commented
May 30, 2024
src/store/modules/TsModsModule.ts
Outdated
| @@ -148,14 +161,61 @@ export const TsModsModule = { | |||
| }, | |||
|
|
|||
| actions: <ActionTree<State, RootState>>{ | |||
| async _fetchPackageListIndex({}): Promise<string[]> { | |||
| // TODO: update GameManager to contain new API endpoint (or read from elsewhere?) | |||
There was a problem hiding this comment.
Is "hardcode endpoint URL for each game separately" still a valid strategy?
There was a problem hiding this comment.
Added a new commit that just replaces the URLs in GameManager. If we want to do something fancier, like only pass a community-slug to the Game constructor and build the API URL internally from that, the changes can easily be thrown away with the commit.
|
@VilppeRiskidev you could also review this, even if only to know what's going on. |
Thunderstore API uses blob files to serve immutable data, as this can be efficiently cached via CDN. The blobs contain stringified JSON that is compressed with gzip to save storage space.
Fetching Lethal Company's package list containing 30k+ mods in one request has been pushing the limits for a while now. For users with slower connections the request timeouts, and the ICP message size limit is soon starting to cause problems. To address these problems, the package list is now downloaded in chunks. Each chunk is a separate blob file that can be heavily cached on CDN level. Chunks are downloaded serially to support slower connections. Caching to IndexedDB is done only when all chunks have been downloaded so transaction can used to make the operation atomic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.