Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LocalModCard performance #1206

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Improve LocalModCard performance #1206

merged 2 commits into from
Feb 15, 2024

Commits on Feb 15, 2024

  1. Move mod card specific dependency calculation into the card component

    @anttimaki
    anttimaki committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    1e55b13 View commit details
    Browse the repository at this point in the history

  2. LocalModCard: tweak how disabled/missing dependencies are gathered 

    - Skip the whole process if the mod has no dependencies
- Combine the methods to avoid looping over the same localModList and
  dependency list multiple times
- Only loop over the localModList (which is the larger of arrays) once
  and return early if all dependencies are found
- Stop appending dash to mod names, it's no longer needed since the new
  implementation doesn't use .startsWith()
- Stop lowercasing the mod names since it doesn't seem to be needed.
  This is more about code clarity than performance.
    @anttimaki
    anttimaki committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0c748a4 View commit details
    Browse the repository at this point in the history