Update InputCapturingStateHover calculation to support collapsed panels #35
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make code "Hajime-spec" :-)
- Make code "Hajime-spec" :-)
hajimehoshi
reviewed
May 2, 2025
context.go
Outdated
| @@ -96,6 +96,10 @@ func (c *Context) update(f func(ctx *Context) error) (inputCapturingState InputC | |||
| // Check whether the cursor is on any of the root containers. | |||
| pt := c.pointingPosition() | |||
| for _, cnt := range c.rootContainers { | |||
| bounds := cnt.layout.Bounds | |||
| if cnt.collapsed { | |||
| bounds.Max.Y -= cnt.layout.BodyBounds.Dy() | |||
There was a problem hiding this comment.
bounds.Max.Y = cnt.layout.BodyBounds.Min.Y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #34 by updating InputCapturingStateHover calculation to support collapsed panels.
This PR fixes an issue where
InputCapturingStateHovercould still be returned for a collapsed window.Problem
When a debug UI window is collapsed, the full
layout.Boundswas still being checked for pointer containment. This meant that even when only the title bar was visible,InputCapturingStateHoverwould be set if the pointer was anywhere in the (now-hidden) body area.Fix
collapsedBoundsrectangle that excludes the body area by subtractingBodyBounds.Dy()from the bottom of the window.collapsedBoundsto determine whether the pointer is hovering over a collapsed window’s visible area (i.e. just the title bar).InputCapturingStateHoverreflects only what is actually visible.