#3504 Tidy test only and final method

ebean-orm · Oct 24, 2024 · 32cd081 · 32cd081
1 parent d8f321d
commit 32cd081
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/...-core/src/main/java/io/ebeaninternal/server/deploy/DynamicPropertyAggregationFormula.java b/...-core/src/main/java/io/ebeaninternal/server/deploy/DynamicPropertyAggregationFormula.java
@@ -63,7 +63,7 @@ public void appendSelect(DbSqlContext ctx, boolean subQuery) {
   }
 
   @Override
-  public void appendGroupBy(DbSqlContext ctx, boolean subQuery) {
+  public final void appendGroupBy(DbSqlContext ctx, boolean subQuery) {
     ctx.appendParseSelect(parsedFormula, null);
   }
 

diff --git a/ebean-test/src/test/java/io/ebean/xtest/base/DtoQuery2Test.java b/ebean-test/src/test/java/io/ebean/xtest/base/DtoQuery2Test.java
@@ -419,8 +419,10 @@ void dto_test_formula_with_group_by() {
 
     List<DCustFormula> ret = query.asDto(DCustFormula.class).findList();
 
-    log.info(query.getGeneratedSql());
-    log.info(ret.toString());
+    String sql = query.getGeneratedSql();
+    assertThat(sql)
+      .describedAs("group by formula only")
+      .contains("from contact t0 group by concat(first_name, last_name) order by custname desc");
     assertThat(ret.get(0).getCustname()).isEqualTo("TracyRed");
     assertThat(ret.get(0).getCnt()).isEqualTo(1L);
   }