Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #273 - Purge coturn #276

Merged
merged 3 commits into from
Jan 26, 2022
Merged

Fix #273 - Purge coturn #276

merged 3 commits into from
Jan 26, 2022

Conversation

BrutalBirdie
Copy link
Collaborator

No description provided.

bbb_turn_enable: true
bbb_stun_servers:
- server: "{{ bbb_hostname }}"
- server: "example.domain.tld"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults should be working or there does not need to be a default. If it is required to set anyway, why create a default for that?

@@ -12,7 +12,8 @@ Also check [Before you install](https://docs.bigbluebutton.org/2.3/install.html#

---

ℹ️ - PR [#275](https://github.com/ebbba-org/ansible-role-bigbluebutton/pull/275) removed the option of installing Greenlight. Please checkout another projoct for Greenlight support
- ℹ️ PR [#275](https://github.com/ebbba-org/ansible-role-bigbluebutton/pull/275) removed the option of installing Greenlight. Please checkout another projoct for Greenlight support
- ℹ️ PR [#276](https://github.com/ebbba-org/ansible-role-bigbluebutton/pull/276) removed the option of installing coturn. Please checkout another projoct for coturn support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an ideal situation there should be a "simple does it all" example. With this role it was possible to set up a complete standalone working BBB instance. Throwing out required stuff for a standalone installation will make it harder to set up BBB.
I am not saying this should be a "this role does everything" like it used to and separation of concern is good, but there should be a similar "get a standalone instance with this example" or "Use these 3 thingies and it works".

"checkout another project" without any hint is not very helpful for this.
For greenlight crosscodr suggested his own role in #272 (comment) which could be easily linked here.
For coturn there are other roles too (which I never used because this rule did just fine). Something that is known to work should be linked here.
Then its easier to get started.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully understandable, I am already working out a solution for this.
But for now I want this PR merged for the next release.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to ask if there is any update on this? I see there is this role: https://github.com/ebbba-org/ansible-role-coturn with two pull requests that might work as drop in replacement?

@BrutalBirdie BrutalBirdie merged commit 0b5ea1f into bbb/2.3 Jan 26, 2022
@BrutalBirdie BrutalBirdie added the enhancement New feature or request label Jan 26, 2022
@BrutalBirdie BrutalBirdie changed the title Fix #273 - Purge coturn Fix #273 - Purge coturn - by @BrutalBirdie Jan 26, 2022
@BrutalBirdie BrutalBirdie changed the title Fix #273 - Purge coturn - by @BrutalBirdie Fix #273 - Purge coturn Jan 26, 2022
@BrutalBirdie BrutalBirdie deleted the fix/remove_coturn branch January 26, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants