Euler: Fix matrix orientation in euler matrix (de)composition#193
Merged
Conversation
The euler_to_matrix and matrix_to_euler code is based on: https://github.com/matthew-brett/transforms3d/blob/master/transforms3d/euler.py This is num-py and has the same row-major matrixes like graphene. However that code is based on column vectors being multiplied with the matrix on the left: > This module implements intrinsic and extrinsic axes, with standard conventions > for axes `i`, `j`, `k`. We assume that the matrix should be applied on the > left of the vector, and right-handed coordinate systems. To get the matrix to > apply on the right of the vector, you need the transpose of the matrix we > supply here, by the matrix transpose rule: $(M . V)^T = V^T M^T$. To do the transpose we just change the matrix indexing macro (M) to swap the row/column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The euler_to_matrix and matrix_to_euler code is based on:
https://github.com/matthew-brett/transforms3d/blob/master/transforms3d/euler.py
This is num-py and has the same row-major matrixes like graphene. However
that code is based on column vectors being multiplied with the matrix on
the left:
To do the transpose we just change the matrix indexing macro (M) to swap
the row/column.