Don't use obsolete isinff and isnanf functions #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNU libc already marks isinff and isnanf functions as obsolete. They have been replaced by isinf and isnan macros defined by C99. Since we already requires C99 in this project, it should be nice if we can switch to standard macros.
|
It currently fails with GCC |
|
I initially used It could very well be a bug in GCC. |
ebassi
pushed a commit
that referenced
this pull request
Jun 6, 2021
Avoids the #ifdef forest and code duplication resulting from it.
There was mismatch in the two code paths, see [1] and [2], and this
commit avoids repeating the same mistake.
While there, use isnan() instead of fpclassify() == FP_NAN for the case
where isnanf() isn't available.
We use isnanf() (if available) instead of isnan() due to [3]:
I initially used isinf() and isnan(), but those ended up breaking
when using GCC because it tried to promote floats to doubles, and
the results wouldn't match any more—especially when using GCC
vectorisation.
It could very well be a bug in GCC.
[1] #223
[2] https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3976
[3] #174 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNU libc already marks isinff and isnanf functions as obsolete. They
have been replaced by isinf and isnan macros defined by C99. Since we
already requires C99 in this project, it should be nice if we can
switch to standard macros.
Proposed changes:
Benchmark results:
Test suite changes: