[t-lTBFjwvE] Upgrade travis PHP to diaginose deprecated warnings #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killertux
force-pushed
the
feature/upgrade-travis
branch
from
24c68c1 to
57a1734
Compare
killertux
force-pushed
the
feature/upgrade-travis
branch
from
57a1734 to
bbe4276
Compare
killertux
commented
Sep 13, 2022
|
|
||
| $selections = $sheet_view->selection; | ||
| for ($i = 0; $i < count($expected_active_cells); $i++) { | ||
| $this->assertNotEmpty($selections[$i]); |
Author
There was a problem hiding this comment.
We cannot assert that an object is not empty anymore. But, since we are validating the internal values of this object, I think that we are safe just removing this assert
killertux
force-pushed
the
feature/upgrade-travis
branch
6 times, most recently
from
41cd3d1 to
441b036
Compare
killertux
force-pushed
the
feature/upgrade-travis
branch
from
441b036 to
9857934
Compare
joaorlima
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.