Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prefs label #147

Merged
merged 1 commit into from
Mar 9, 2022
Merged

fix prefs label #147

merged 1 commit into from
Mar 9, 2022

Conversation

ericfont
Copy link
Contributor

What was previously written seems unintended. It meant that hovering over "Preferences" label would result undesirebly in the "Reboot" button being highlighted, and thus clicking on "Preferences" would try to reboot the ESP32.

But by changing the "for=" for the preferences label from "reboot" to "prefs" it is now unique and doesn't get confused with "reboot".

@Herremelk
Copy link

It would be nice to have this "hover-over-with-mouse-text-effect" on all the camera settings, what all the things shortened with three capital letters are, is a bit hard to remember

@easytarget
Copy link
Owner

It would be nice to have this "hover-over-with-mouse-text-effect" on all the camera settings, what all the things shortened with three capital letters are, is a bit hard to remember

I have thought this too; but I'm not going to troll through the documentation then scratch my head trying to find a short but understandable label for every control.. Sorry, but I'd rather invest my time elsewhere.

That said:

  • It probably only needs to be for controls with acronyms or technical terms in them, and doesn't need to be in in-depth guide.
  • If someone else wants to have a go at the description part; it wouldn't be hard to mod the html and add the labels.
  • do it for both the ov2640 and the 0v3660.. (they have differences)

@easytarget
Copy link
Owner

I'll look at the PR asap; I'll be doing a quick clean-up here this week.

@easytarget easytarget merged commit b1db350 into easytarget:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants