-
-
Notifications
You must be signed in to change notification settings - Fork 21
marginaleffects
: Do not use attributes like posterior_draws
#557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the package version and adds marginaleffects
to the Remotes
in the DESCRIPTION file. While the changes are functional, I have provided two suggestions to improve maintainability and reproducibility. The first recommends a minor version bump to align with semantic versioning, given the new features introduced. The second suggests pinning the remote dependency to a specific reference to ensure consistent builds.
@gemini-code-assist review |
Fixes #556
Fixed packages:
Waiting for vincentarelbundock/marginaleffects#1570