Skip to content

Prepare CRAN release#1128

Merged
strengejacke merged 2 commits into
mainfrom
rc_1_4_1
Aug 29, 2025
Merged

Prepare CRAN release#1128
strengejacke merged 2 commits into
mainfrom
rc_1_4_1

Conversation

@strengejacke
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request prepares the 'insight' R package for a new CRAN release by bumping its version to 1.4.1. The primary changes involve updating the required minimum version for the 'marginaleffects' dependency to 0.29.0 across various functions, examples, and tests. Additionally, the 'Remotes' field has been removed from the package description, indicating that 'marginaleffects' and 'modelbased' are now stable enough to be sourced from CRAN or other standard repositories, simplifying package management.

Highlights

  • Version Bump: The package version has been incremented from 1.4.0.15 to 1.4.1, signaling a new release.
  • Dependency Update: The minimum required version for the 'marginaleffects' package has been updated across the codebase and in the DESCRIPTION file from 0.26.0 (or 0.28.0.22 in some code checks) to 0.29.0. This ensures compatibility with the latest features and fixes of 'marginaleffects'.
  • Removed Development Remotes: The 'Remotes' field, which previously pointed to development versions of 'marginaleffects' and 'modelbased' on GitHub, has been removed from the DESCRIPTION file. This change implies that these packages are now expected to be available from standard repositories, streamlining the installation process for users.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares the package for a CRAN release by updating the version number and the minimum required version for the marginaleffects dependency. The changes are consistent and look correct. I've added several suggestions to improve maintainability by removing redundant minimum_version arguments in check_if_installed() and skip_if_not_installed() calls. This is possible because the function can automatically infer the required version from the DESCRIPTION file, which simplifies future dependency updates.

Comment thread R/find_formula.R
Comment thread R/get_datagrid.R
Comment thread R/get_datagrid.R
Comment thread R/helper_functions.R
Comment thread R/is_mixed_model.R
Comment thread tests/testthat/test-get_datagrid.R
Comment thread tests/testthat/test-get_datagrid.R
Comment thread tests/testthat/test-get_datagrid.R
Comment thread tests/testthat/test-marginaleffects.R
Comment thread tests/testthat/test-marginaleffects.R
@strengejacke strengejacke merged commit f67fd93 into main Aug 29, 2025
15 of 19 checks passed
@strengejacke strengejacke deleted the rc_1_4_1 branch August 29, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant