Skip to content

Commit

Permalink
[chore] bump go version for linting (open-telemetry#23346)
Browse files Browse the repository at this point in the history
After digging into what was causing linting time outs, it looks like golangci-lint was using up a significant amount of memory to run lint against otelcontribcol. After digging I came across this issue that mentions memory usage: golangci/golangci-lint#3565 (comment)

I've tested bumping the linters to go 1.20 and so far it looks like the avg memory is lower than it was w/ go 1.19. I've also enabled verbose logging for linting to give us a bit more info when there are issues.

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
  • Loading branch information
Alex Boten authored Jun 14, 2023
1 parent d79f3c0 commit 31bfef7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: 1.19
go-version: "1.20"
cache: false
- name: Cache Go
id: go-cache
Expand Down
2 changes: 1 addition & 1 deletion Makefile.Common
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ fmt: $(GOIMPORTS)

.PHONY: lint
lint: $(LINT) checklicense misspell
$(LINT) run --allow-parallel-runners --build-tags integration --path-prefix $(shell basename "$(CURDIR)")
$(LINT) run --allow-parallel-runners --verbose --build-tags integration --path-prefix $(shell basename "$(CURDIR)")

.PHONY: govulncheck
govulncheck: $(GOVULNCHECK)
Expand Down

0 comments on commit 31bfef7

Please sign in to comment.