Fix or avoid warnings that commonly arise in build log #3129
+204
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 13, 2019
Flamefire
force-pushed
the
fix_exts_filter
branch
from
b9f08a4 to
afce2f6
Compare
boegel
requested changes
Dec 15, 2019
houndci-bot
reviewed
Dec 16, 2019
Flamefire
force-pushed
the
fix_exts_filter
branch
2 times, most recently
from
6fb973f to
63d8bbb
Compare
houndci-bot
reviewed
Dec 16, 2019
Flamefire
force-pushed
the
fix_exts_filter
branch
from
63d8bbb to
fbc43de
Compare
Flamefire
force-pushed
the
fix_exts_filter
branch
from
fbc43de to
0cc371e
Compare
houndci-bot
reviewed
Jan 6, 2020
|
ping |
boegel
requested changes
Jan 14, 2020
Just get the value w/o template replacements for logging Adresses easybuilders#3124
- Avoid duplicated code in EasyBlock and Extension - Fix wrong attribute 'source' accessed instead of 'src' - Enhance testcase to detect above issue - Remove deprecated (and supposedly in v2.0 removed) template args Fixes easybuilders#3124
Removes duplicate "Command found" message in check_cmd_avail
Removes expected warning message when checking for cmd before using COMMAND_ENVIRONMENT
Reasoning: Usually commands 'ml'/'module' are used which internally use LMOD_CMD
so lmod does not need to be in path (and rarely is)
…_lists Some values are not available at this stage, e.g. installdir As we are not interested in the resolved values, simply disable templating
We just need to number of elements, not their values
This happens for e.g. _opt_CC and friends and is allowed to be empty/unset according to the code in the setter function. This avoids half a dozen warnings per software part installed
Flamefire
force-pushed
the
fix_exts_filter
branch
from
073ffdc to
5c4d4b7
Compare
boegel
changed the title
boegel
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log of any software contains a lot of warnings from EasyBuild. This PR reduces those considerably. Every change is in its own commit, but all have this common goal, so they are bundled here.
exts_filter, fixes Fix usage of 'exts_filter' #3124whichwhen existance of command is checked and (semi-)expected to fail. This avoids duplicate log messages and warningsdet_iter_cntandvalidate_iterate_opt_listsdon't need templating and produce warnings if they use it_opt_CCand friends producing warnings although empty values are ok