check_os_dependency: Handle the fact that get_os_name can produce RHEL and SL* #3072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
Nov 9, 2019
easybuild/tools/systemtools.py
Outdated
| } | ||
| os_name = get_os_name() | ||
|
|
||
| rh_based_os = any(os_name.startswith(x) for x in ['centos', 'fedora', 'redhat', 'rhel', 'sl']) |
There was a problem hiding this comment.
Isn't the startswith('sl') a bit risky? That's not exactly strict... Slackware for example?
There was a problem hiding this comment.
It probably is, I just took that from some other part of EasyBuild.
Like tensorflow.py
There was a problem hiding this comment.
@boegel Better now?
|
@boegel Better now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And handle fedora as well.