Build rpm for Java-1.8.eb fails

[AnibalMG]

I am getting an error when I try to generate the rpm for Java-1.8.eb.
FPM could not fine the lua files because the modulerc easyblock is only genereting the .modulerc file.

== 2019-01-30 08:48:59,358 build_log.py:251 INFO packaging...
== 2019-01-30 08:48:59,358 easyblock.py:2610 INFO Starting package step
== 2019-01-30 08:48:59,359 easyblock.py:2616 INFO Running method package_step part of step package
== 2019-01-30 08:48:59,359 easyblock.py:2031 INFO Generating rpm package in /tmp
== 2019-01-30 08:48:59,359 utilities.py:84 INFO Will be creating rpm package(s) in /tmp/eb-SbnuSD/eb-pkgs-97NtDB
== 2019-01-30 08:48:59,361 run.py:192 INFO running cmd: ['/usr/bin/env', 'fpm', '--workdir', '/tmp/eb-SbnuSD/eb-pkgs-97NtDB', '--name', 'Java-1.8', '--provides', 'Java-1.8', '-t', 'rpm', '-s', 'dir', '--version', 'eb-3.8.0', '--iteration', '1', '--description', 'Java Platform, Standard Edition (Java SE) lets you develop and deploy\n Java applications on desktops and servers.', '--url', 'http://java.com/', '--depends', 'Java-1.8.0_201', '--exclude', '.local/easybuild/software/Java/1.8/easybuild/*.log', '--exclude', '.local/easybuild/software/Java/1.8/easybuild/*.md', '.local/easybuild/software/Java/1.8', .local/easybuild/modules/all/Java/1.8.lua'] 
== 2019-01-30 08:49:00,089 build_log.py:162 ERROR EasyBuild crashed with an error (at easybuild/software/EasyBuild/3.8.0/lib/python2.6/site-packages/vsc_base-2.8.3-py2.6.egg/vsc/utils/exceptions.py:124 in __init__): cmd "['/usr/bin/env', 'fpm', '--workdir', '/tmp/eb-SbnuSD/eb-pkgs-97NtDB', '--name', 'Java-1.8', '--provides', 'Java-1.8', '-t', 'rpm', '-s', 'dir', '--version', 'eb-3.8.0', '--iteration', '1', '--description', 'Java Platform, Standard Edition (Java SE) lets you develop and deploy\n Java applications on desktops and servers.', '--url', 'http://java.com/', '--depends', 'Java-1.8.0_201', '--exclude', '/.local/easybuild/software/Java/1.8/easybuild/*.log', '--exclude', '.local/easybuild/software/Java/1.8/easybuild/*.md', '.local/easybuild/software/Java/1.8', '.local/easybuild/modules/all/Java/1.8.lua']" exited with exit code 1 and output:
{:timestamp=>"2019-01-30T08:49:00.019756+0000", :message=>"Invalid package configuration: Cannot package the path '/.local/easybuild/modules/all/Java/1.8.lua', does it exist?", :level=>:error}
 (at easybuild/software/EasyBuild/3.8.0/lib/python2.6/site-packages/easybuild_framework-3.8.0-py2.6.egg/easybuild/tools/run.py:501 in parse_cmd_output)
== 2019-01-30 08:49:00,089 easyblock.py:2864 WARNING build failed (first 300 chars): cmd "['/usr/bin/env', 'fpm', '--workdir', '/tmp/eb-SbnuSD/eb-pkgs-97NtDB', '--name', 'Java-1.8', '--provides', 'Java-1.8', '-t', 'rpm', '-s', 'dir', '--version', 'eb-3.8.0', '--iteration', '1', '--description', 'Java Platform, Standard Edition (Java SE) lets you develop and deploy\n Java application
== 2019-01-30 08:49:00,089 easyblock.py:286 INFO Closing log for application name Java version 1.8

I saw the issue on EB 3.7.1 and 3.8.0.

[boegel]

So the problem is basically that the packaging logic expects to find a module file Java/1.8.lua, but there is none?

This is a tricky one to solve, since the .modulerc.lua is not owned only by Java/1.8, you could have another module wrapper for Java/1.9 as well for example (which would also be registered in .modulerc.lua)...

[Micket]

Embed some sort of install-script that performs this step (in an otherwise empty RPM)?

[boegel]

It may make sense to consult @rtmclay on this one...

How does TACC handle installations that involve touching Java/.modulerc.lua to register a short-hand version like 1.8 for 1.8.0_212?

[rtmclay]

Well, we only install java occasionally and only the system one. But we do have a similar problem with our .version files for all packages.

What we do is have each rpm package that has a module file also create a .version.X.Y.Z file where X.Y.Z is the version (so a .version.1.8.0_212 in this case). Then a separate tool creates a symlink between .version and .version.X.Y.Z.

Normally, we can use the highest version to be the default but sometimes version 1.8 is preferred over 1.9 say. So in those cases, we create a symlink between the .version.X.Y.Z and .version

[boegel]

@rtmclay That approach won't work here though, since the Java/.modulerc.lua may have to contain multiple module_version statements, each of which tied to a different software version (and hence separate package)...

Can we avoid that somehow?

[rtmclay]

You can't. You can't have one file shared by multiple rpm. The solution is to not put .modulerc.lua in the rpm.

[boegel]

@rtmclay Is there a way to have multiple .modulerc files in a single directory?

For the Java/1.8 and Java/11 wrappers, literally the only thing to install/change is the .modulerc.lua, so not including it in the RPM is not really a good option ;)

[boegel]

Idea pitched by @Micket: how about letting Lmod support a .modulerc/ directory?

That way each Java wrapper could own a separate file in that directory...