Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using --buildtype=release in easyconfigs using MesonNinja easyblock #21619

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

Micket
Copy link
Contributor

@Micket Micket commented Oct 10, 2024

@Micket
Copy link
Contributor Author

Micket commented Oct 10, 2024

Test report by @Micket
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3454
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/18087124489f6e00fd77d58b05983c3b for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented Oct 11, 2024

perhaps worth adding a CI check that catches new easyconfigs that use --buildtype release etc?

jfgrimm
jfgrimm previously approved these changes Oct 14, 2024
Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Fix flags for updated mesonninja easyblock Fix flags for updated MesonNinja easyblock Oct 14, 2024
@boegel boegel changed the title Fix flags for updated MesonNinja easyblock stop using --buildtype=release in easyconfigs using MesonNinja easyblock Oct 14, 2024
test/easyconfigs/easyconfigs.py Outdated Show resolved Hide resolved
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
@boegel
Copy link
Member

boegel commented Oct 15, 2024

Test report by @boegel
SUCCESS
Build succeeded for 58 out of 58 (58 easyconfigs in total)
node3508.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/boegel/dd87c0fa03817aa050c790792b06f310 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 15, 2024

Going in, thanks @Micket!

@boegel boegel merged commit 392db74 into easybuilders:5.0.x Oct 15, 2024
7 checks passed
@Micket Micket deleted the meson branch October 15, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Nice-to-have
Development

Successfully merging this pull request may close these issues.

3 participants