Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configure options of FFLAS-FFPACK #20052

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Mar 6, 2024

(created using eb --new-pr)

GMP is found by using Givaro:

2.2.0 configure.ac:# Getting GMP from Givaro - AB 2014-12-12
2.5.0 configure.ac:# Looking for Givaro. We get the flags for GMP at the same time

The --with-gmp flag was removed in 2.1

The --with-givaro flag was replaced by a pkg-config check in 2.4.3/2.5.0

Caution: I also updated the old EC (2016a) which I can't build anymore.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
n1358 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/03272c0acfa246f62cdc60af0de7683c for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added the bug fix label Mar 13, 2024
@Micket Micket added this to the release after 4.9.0 milestone Mar 13, 2024
@Micket
Copy link
Contributor

Micket commented Mar 13, 2024

Test report by @Micket
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/cc1feb852b9069422ec84a579ce2daf5 for a full test report.

@Micket
Copy link
Contributor

Micket commented Mar 13, 2024

Going in, thanks @Flamefire!

@Micket Micket merged commit f055424 into easybuilders:develop Mar 13, 2024
9 checks passed
@Flamefire Flamefire deleted the 20240306144237_new_pr_FFLAS-FFPACK220 branch March 14, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants