Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python configure option of MEME #20043

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Mar 5, 2024

(created using eb --new-pr)

The --with-python3 option was removed in at least 5.1.1 and --with-python needs to be used. 5.0.4 has both

@jfgrimm
Copy link
Member

jfgrimm commented Mar 5, 2024

@boegelbot please test @ generoso
CORE_CNT=16

@jfgrimm jfgrimm added the bug fix label Mar 5, 2024
@jfgrimm jfgrimm added this to the release after 4.9.0 milestone Mar 5, 2024
@boegelbot
Copy link
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=20043 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20043 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13031

Test results coming soon (I hope)...

- notification for comment with ID 1979132325 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 3 out of 4 (4 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/22640ce0b3cbe9cb43bfdac01a6aa438 for a full test report.

Copy link
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failure is because it doesn't have a license for the intel compiler, lgtm

@jfgrimm
Copy link
Member

jfgrimm commented Mar 5, 2024

Going in, thanks @Flamefire!

@jfgrimm jfgrimm merged commit cc60486 into easybuilders:develop Mar 5, 2024
9 checks passed
@Flamefire Flamefire deleted the 20240305160510_new_pr_MEME504 branch March 5, 2024 18:41
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
n1358 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/834d8c8b91141105f7b5b889131b11b5 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants